Well, this post came a bit late as I was busy with my coding stuff.
The coding period started almost 2 weeks ago and in these 2 weeks I mainly worked on making ticket update work properly and also work on some GUI part of tickets. During this I came to know that this update problem is not only with the ticket items but all items which do not have any name. Also there was a failing unit test due to this. The problem was that the notification module was dependent on name and as items may not have any name so the error was raised whenever such an item was modified. For solving this I passed fqname instead of item_name to Notification module and also to logging signals and used this fqname to fetch the item's information and send notification mail. Here is the codereview and commit to my repo.
There was also one specific problem with tickets that for the fields "Depends On" and "Superseded By" it was earlier trying to fetch the names of other tickets and tickets do not have any name so an error was raised. For this problem I made it fetch only some initials of itemid and also summary of the ticket items. Now in these fields the drop-down list shows this itemid initials and summary. Here is the codereview for my change. I am yet to commit it to my repo.
Also during this time Ajitesh (:randomax) reminded me of this bug regarding the dislocation of search box which I solved earlier but didn't commit. So I committed that also to my repo. Here is the codereview and commit to my repo.
The coding period started almost 2 weeks ago and in these 2 weeks I mainly worked on making ticket update work properly and also work on some GUI part of tickets. During this I came to know that this update problem is not only with the ticket items but all items which do not have any name. Also there was a failing unit test due to this. The problem was that the notification module was dependent on name and as items may not have any name so the error was raised whenever such an item was modified. For solving this I passed fqname instead of item_name to Notification module and also to logging signals and used this fqname to fetch the item's information and send notification mail. Here is the codereview and commit to my repo.
There was also one specific problem with tickets that for the fields "Depends On" and "Superseded By" it was earlier trying to fetch the names of other tickets and tickets do not have any name so an error was raised. For this problem I made it fetch only some initials of itemid and also summary of the ticket items. Now in these fields the drop-down list shows this itemid initials and summary. Here is the codereview for my change. I am yet to commit it to my repo.
Also during this time Ajitesh (:randomax) reminded me of this bug regarding the dislocation of search box which I solved earlier but didn't commit. So I committed that also to my repo. Here is the codereview and commit to my repo.
No comments:
Post a Comment